[opt](agg) Optimize the execution of GROUP BY count(*).#61260
Open
Mryange wants to merge 4 commits intoapache:masterfrom
Open
[opt](agg) Optimize the execution of GROUP BY count(*).#61260Mryange wants to merge 4 commits intoapache:masterfrom
Mryange wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 27585 ms |
TPC-DS: Total hot run time: 154734 ms |
Mryange
force-pushed
the
opt-inline-agg-count
branch
from
8497d2a to
ce542e0
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26408 ms |
TPC-DS: Total hot run time: 169263 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
force-pushed
the
opt-inline-agg-count
branch
from
ce542e0 to
5ce94ed
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27072 ms |
TPC-DS: Total hot run time: 169621 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
/review |
1 similar comment
Contributor
|
/review |
HappenLee
reviewed
Mar 19, 2026
| ->create_serialize_column(); | ||
| } | ||
|
|
||
| std::vector<UInt64> inline_counts(size); |
Contributor
There was a problem hiding this comment.
why here do not directly use auto& count_col = assert_cast<ColumnFixedLengthObject&>(*value_columns[0]); count_col.resize(num_rows); ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For SQL like:
we can apply the following optimization:
In the agg hashmap<key, value>, the value is a char*, which happens to be 64-bit. We can treat this pointer directly as a uint64 counter. This avoids creating an AggState. However, this introduces extra if/else branches in many places where we operate on the hashmap. We plan to refactor this area in the future.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)